Add support for typevar attribute target specifier#354
Merged
Conversation
- Added typevar to attribute-section pattern (placed before type to ensure proper matching) - Added test cases for typevar attribute specifier - All tests passing (895 tests) Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix classification issue for typevar keyword
Add support for Dec 20, 2025
typevar attribute target specifier
JoeRobich
approved these changes
Dec 20, 2025
dibarbet
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
typevarattribute target specifier (C# 13) was not recognized, causing it to be incorrectly tokenized as separatetypeandvartokens.Changes
typevarto the attribute-section pattern insrc/csharp.tmLanguage.ymltypein the regex alternation to prevent premature matchingtypevarattribute specifierExample
Before:
typevarhighlighted as two separate tokens (type+var)After:
typevarhighlighted as a single keyword attribute specifierOriginal prompt
typevarkeyword #320✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.